Skip to content

feat: add hotkeys for moving focus prev or next in guide toolbar#966

Merged
thomaswhyyou merged 3 commits intomainfrom
thomas-kno-12729-feedback-on-keyboard-navigation-in-focus-mode
Apr 17, 2026
Merged

feat: add hotkeys for moving focus prev or next in guide toolbar#966
thomaswhyyou merged 3 commits intomainfrom
thomas-kno-12729-feedback-on-keyboard-navigation-in-focus-mode

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Apr 17, 2026

Description

Adds additional hotkeys to guide toolbar, per this feedback:

  • ctrl + ,: Moves focus to previous guide
  • ctrl + /: Moves focus to next guide

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Apr 17, 2026 9:25pm
javascript-nextjs-example Ready Ready Preview, Comment Apr 17, 2026 9:25pm
javascript-slack-connect-example Ready Ready Preview, Comment Apr 17, 2026 9:25pm
javascript-slack-kit-example Ready Ready Preview, Comment Apr 17, 2026 9:25pm

Request Review

@linear
Copy link
Copy Markdown

linear Bot commented Apr 17, 2026

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2026

🦋 Changeset detected

Latest commit: cd2c008

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@knocklabs/react Patch
guide-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor Author

thomaswhyyou commented Apr 17, 2026

@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fec871b. Configure here.

@thomaswhyyou thomaswhyyou marked this pull request as ready for review April 17, 2026 20:36
@thomaswhyyou thomaswhyyou merged commit 9d81dc2 into main Apr 17, 2026
11 of 13 checks passed
@thomaswhyyou thomaswhyyou deleted the thomas-kno-12729-feedback-on-keyboard-navigation-in-focus-mode branch April 17, 2026 21:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 7.92079% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.82%. Comparing base (e474413) to head (cd2c008).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../modules/guide/components/Toolbar/V2/FocusChin.tsx 5.81% 81 Missing ⚠️
...ct/src/modules/guide/components/Toolbar/V2/Kbd.tsx 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   64.04%   63.82%   -0.23%     
==========================================
  Files         209      210       +1     
  Lines       10086    10133      +47     
  Branches     1304     1304              
==========================================
+ Hits         6460     6467       +7     
- Misses       3601     3641      +40     
  Partials       25       25              
Files with missing lines Coverage Δ
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 10.09% <100.00%> (+0.35%) ⬆️
...ct/src/modules/guide/components/Toolbar/V2/Kbd.tsx 14.28% <14.28%> (ø)
.../modules/guide/components/Toolbar/V2/FocusChin.tsx 9.34% <5.81%> (+0.58%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants